This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
feat: Messaging tab visibility #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md See merge request olcs/olcs-selfserve!1320
hobbyhacker0
changed the title
wadedvsa
reviewed
Jan 26, 2024
wadedvsa
approved these changes
Jan 26, 2024
jerotire
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Looks good to me, and yeah make https://github.com/dvsa/olcs-selfserve/pull/32/files#r1467568136 right 😄
jerotire
added a commit
that referenced
this pull request
Feb 16, 2024
* feat: OLCS composer packages to dev-project/messaging (#19) * feat: Messaging conversation list (#22) * feat: Messaging conversation list * fix: Missing route from branch re-create * fix: Rename messages to conversations * fix: Unused null check * feat: Update olcs-comon lock * feat: List messages in a conversation. (#23) * feat: Conversation messages list * feat: Controller view test * fix: Unused null check * fix: Test PR changes (case and unused var) * fix: Just added whitespace! * feat: Messaging tab visibility (#32) * Update README.md * WIP * Tab WIP * Messaging tab view based on feature toggle only * Messaging tab logic without extra query * Change routing to conversations * Clean unused * Review improvement * Revert whitespace from bad resolution --------- Co-authored-by: Joshua License <[email protected]> Co-authored-by: Saul Wilcox <[email protected]> * feat: Project branch change for composer.lock * feat: Composer update due to common and transfer merges from main * fix: Navigation unit test (#36) * Add messaging feature in NavigationTest * fix: Add once() assertions to shouldReceive() * Fix test to match CI error_reporting * Formatting improvements --------- Co-authored-by: Saul Wilcox <[email protected]> * feat: Message list split in to two columns (#41) * feat: Message list split in to two columns * feat: composer.lock * feat: Start conversation link (#45) * feat: Start a new conversation link (and empty page) * fix: PR: Rename newAction to addAction * feat: Add header to new sidebar for start link (#50) * feat: Reply to conversation (#49) * feat: Reply to a conversation * fix: Strong types on form * feat: Messsaging new conversation form (#53) * chore: so far * chore: so far * chore: so far * olcs-transfer bump * feat: use GOVUK-SELECT class * chore: code clean-up * bump: olcs-common * chore: bump olcs-common and olcs-transfer * Add "Messaging not disabled" to tab display conditions (#57) * Add condition for messaging disabled for organisation * Adjust to match call count * Add full return to tests * Whitespace --------- Co-authored-by: Saul Wilcox <[email protected]> * fix: Trying to access array key on null in navigation (#60) * fix: swapped container interface interop for Psr (#62) * chore: form annotation changes (#63) * chore: revert composer.json/lock to use non-messaging project branches (#64) --------- Co-authored-by: Wade Womersley <[email protected]> Co-authored-by: Saul Wilcox <[email protected]> Co-authored-by: Joshua License <[email protected]> Co-authored-by: Saul Wilcox <[email protected]>
wadedvsa
added a commit
that referenced
this pull request
Feb 19, 2024
* feat: OLCS composer packages to dev-project/messaging (#19) * feat: Messaging conversation list (#22) * feat: Messaging conversation list * fix: Missing route from branch re-create * fix: Rename messages to conversations * fix: Unused null check * feat: Update olcs-comon lock * feat: List messages in a conversation. (#23) * feat: Conversation messages list * feat: Controller view test * fix: Unused null check * fix: Test PR changes (case and unused var) * fix: Just added whitespace! * feat: Messaging tab visibility (#32) * Update README.md * WIP * Tab WIP * Messaging tab view based on feature toggle only * Messaging tab logic without extra query * Change routing to conversations * Clean unused * Review improvement * Revert whitespace from bad resolution --------- Co-authored-by: Joshua License <[email protected]> Co-authored-by: Saul Wilcox <[email protected]> * feat: Project branch change for composer.lock * feat: Composer update due to common and transfer merges from main * fix: Navigation unit test (#36) * Add messaging feature in NavigationTest * fix: Add once() assertions to shouldReceive() * Fix test to match CI error_reporting * Formatting improvements --------- Co-authored-by: Saul Wilcox <[email protected]> * feat: Message list split in to two columns (#41) * feat: Message list split in to two columns * feat: composer.lock * feat: Start conversation link (#45) * feat: Start a new conversation link (and empty page) * fix: PR: Rename newAction to addAction * feat: Add header to new sidebar for start link (#50) * feat: Reply to conversation (#49) * feat: Reply to a conversation * fix: Strong types on form * feat: Messsaging new conversation form (#53) * chore: so far * chore: so far * chore: so far * olcs-transfer bump * feat: use GOVUK-SELECT class * chore: code clean-up * bump: olcs-common * chore: bump olcs-common and olcs-transfer * Add "Messaging not disabled" to tab display conditions (#57) * Add condition for messaging disabled for organisation * Adjust to match call count * Add full return to tests * Whitespace --------- Co-authored-by: Saul Wilcox <[email protected]> * fix: Trying to access array key on null in navigation (#60) * fix: Disable reply on closed conversations * fix: Test fix * fix: Pull composer.json from main --------- Co-authored-by: Saul Wilcox <[email protected]> Co-authored-by: Joshua License <[email protected]> Co-authored-by: Saul Wilcox <[email protected]> Co-authored-by: James Wragg <[email protected]>
jerotire
added a commit
to dvsa/vol-app
that referenced
this pull request
Aug 16, 2024
* feat: OLCS composer packages to dev-project/messaging (dvsa/olcs-selfserve#19) * feat: Messaging conversation list (dvsa/olcs-selfserve#22) * feat: Messaging conversation list * fix: Missing route from branch re-create * fix: Rename messages to conversations * fix: Unused null check * feat: Update olcs-comon lock * feat: List messages in a conversation. (dvsa/olcs-selfserve#23) * feat: Conversation messages list * feat: Controller view test * fix: Unused null check * fix: Test PR changes (case and unused var) * fix: Just added whitespace! * feat: Messaging tab visibility (dvsa/olcs-selfserve#32) * Update README.md * WIP * Tab WIP * Messaging tab view based on feature toggle only * Messaging tab logic without extra query * Change routing to conversations * Clean unused * Review improvement * Revert whitespace from bad resolution --------- Co-authored-by: Joshua License <[email protected]> Co-authored-by: Saul Wilcox <[email protected]> * feat: Project branch change for composer.lock * feat: Composer update due to common and transfer merges from main * fix: Navigation unit test (dvsa/olcs-selfserve#36) * Add messaging feature in NavigationTest * fix: Add once() assertions to shouldReceive() * Fix test to match CI error_reporting * Formatting improvements --------- Co-authored-by: Saul Wilcox <[email protected]> * feat: Message list split in to two columns (dvsa/olcs-selfserve#41) * feat: Message list split in to two columns * feat: composer.lock * feat: Start conversation link (dvsa/olcs-selfserve#45) * feat: Start a new conversation link (and empty page) * fix: PR: Rename newAction to addAction * feat: Add header to new sidebar for start link (dvsa/olcs-selfserve#50) * feat: Reply to conversation (dvsa/olcs-selfserve#49) * feat: Reply to a conversation * fix: Strong types on form * feat: Messsaging new conversation form (dvsa/olcs-selfserve#53) * chore: so far * chore: so far * chore: so far * olcs-transfer bump * feat: use GOVUK-SELECT class * chore: code clean-up * bump: olcs-common * chore: bump olcs-common and olcs-transfer * Add "Messaging not disabled" to tab display conditions (dvsa/olcs-selfserve#57) * Add condition for messaging disabled for organisation * Adjust to match call count * Add full return to tests * Whitespace --------- Co-authored-by: Saul Wilcox <[email protected]> * fix: Trying to access array key on null in navigation (dvsa/olcs-selfserve#60) * fix: swapped container interface interop for Psr (dvsa/olcs-selfserve#62) * chore: form annotation changes (dvsa/olcs-selfserve#63) * chore: revert composer.json/lock to use non-messaging project branches (dvsa/olcs-selfserve#64) --------- Co-authored-by: Wade Womersley <[email protected]> Co-authored-by: Saul Wilcox <[email protected]> Co-authored-by: Joshua License <[email protected]> Co-authored-by: Saul Wilcox <[email protected]>
jerotire
added a commit
to dvsa/vol-app
that referenced
this pull request
Aug 16, 2024
* feat: OLCS composer packages to dev-project/messaging (dvsa/olcs-selfserve#19) * feat: Messaging conversation list (dvsa/olcs-selfserve#22) * feat: Messaging conversation list * fix: Missing route from branch re-create * fix: Rename messages to conversations * fix: Unused null check * feat: Update olcs-comon lock * feat: List messages in a conversation. (dvsa/olcs-selfserve#23) * feat: Conversation messages list * feat: Controller view test * fix: Unused null check * fix: Test PR changes (case and unused var) * fix: Just added whitespace! * feat: Messaging tab visibility (dvsa/olcs-selfserve#32) * Update README.md * WIP * Tab WIP * Messaging tab view based on feature toggle only * Messaging tab logic without extra query * Change routing to conversations * Clean unused * Review improvement * Revert whitespace from bad resolution --------- Co-authored-by: Joshua License <[email protected]> Co-authored-by: Saul Wilcox <[email protected]> * feat: Project branch change for composer.lock * feat: Composer update due to common and transfer merges from main * fix: Navigation unit test (dvsa/olcs-selfserve#36) * Add messaging feature in NavigationTest * fix: Add once() assertions to shouldReceive() * Fix test to match CI error_reporting * Formatting improvements --------- Co-authored-by: Saul Wilcox <[email protected]> * feat: Message list split in to two columns (dvsa/olcs-selfserve#41) * feat: Message list split in to two columns * feat: composer.lock * feat: Start conversation link (dvsa/olcs-selfserve#45) * feat: Start a new conversation link (and empty page) * fix: PR: Rename newAction to addAction * feat: Add header to new sidebar for start link (dvsa/olcs-selfserve#50) * feat: Reply to conversation (dvsa/olcs-selfserve#49) * feat: Reply to a conversation * fix: Strong types on form * feat: Messsaging new conversation form (dvsa/olcs-selfserve#53) * chore: so far * chore: so far * chore: so far * olcs-transfer bump * feat: use GOVUK-SELECT class * chore: code clean-up * bump: olcs-common * chore: bump olcs-common and olcs-transfer * Add "Messaging not disabled" to tab display conditions (dvsa/olcs-selfserve#57) * Add condition for messaging disabled for organisation * Adjust to match call count * Add full return to tests * Whitespace --------- Co-authored-by: Saul Wilcox <[email protected]> * fix: Trying to access array key on null in navigation (dvsa/olcs-selfserve#60) * fix: Disable reply on closed conversations * fix: Test fix * fix: Pull composer.json from main --------- Co-authored-by: Saul Wilcox <[email protected]> Co-authored-by: Joshua License <[email protected]> Co-authored-by: Saul Wilcox <[email protected]> Co-authored-by: James Wragg <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logic for display of Messaging tab (linking to conversations)
Related issue: VOL-4713
Before submitting (or marking as "ready for review")