Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

fix: Only show valid fees for licences #137

Merged
merged 1 commit into from
May 7, 2024
Merged

fix: Only show valid fees for licences #137

merged 1 commit into from
May 7, 2024

Conversation

wadedvsa
Copy link
Contributor

Description

Only show fees for submitted applications.

Related issue: VOL-233

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

jerotire
jerotire previously approved these changes May 3, 2024
View reviewed changes
fibble
fibble previously approved these changes May 7, 2024
View reviewed changes
@wadedvsa @fibble
# This is a combination of 3 commits.
49bd0d1 
# This is the 1st commit message:

fix: Only show valid fees for licences

# This is the commit message #2:

chore: olcs-transfer bump

# This is the commit message #3:

fix: bump transfer dependency to minium version reqd for this bugfix
@fibble fibble dismissed stale reviews from jerotire and themself via 49bd0d1 May 7, 2024 08:59
@fibble fibble force-pushed the bugfix/VOL-233-ignore-irrelevant-fees branch from 20c6ae2 to 49bd0d1 Compare May 7, 2024 08:59
@JoshuaLicense JoshuaLicense merged commit da9a96b into main May 7, 2024
6 checks passed
@JoshuaLicense JoshuaLicense deleted the bugfix/VOL-233-ignore-irrelevant-fees branch May 7, 2024 10:06
@github-actions github-actions bot mentioned this pull request May 7, 2024
Open
JoshuaLicense added a commit that referenced this pull request May 10, 2024
@JoshuaLicense
Revert "fix: only show valid fees for licences (#137)"
ad80014 
This reverts commit da9a96b.
@JoshuaLicense JoshuaLicense mentioned this pull request May 10, 2024
Merged
JoshuaLicense added a commit that referenced this pull request May 10, 2024
@JoshuaLicense
chore: revert "fix: only show valid fees for licences (#137)" (#143)
bfd6b6f 
This reverts commit da9a96b.
jerotire pushed a commit to dvsa/vol-app that referenced this pull request Aug 16, 2024
@wadedvsa
fix: only show valid fees for licences (dvsa/olcs-selfserve#137)
2292fa3 
# This is the 1st commit message:

fix: Only show valid fees for licences

# This is the commit message #2:

chore: olcs-transfer bump

# This is the commit message #3:

fix: bump transfer dependency to minium version reqd for this bugfix
jerotire pushed a commit to dvsa/vol-app that referenced this pull request Aug 16, 2024
@JoshuaLicense
chore: revert "fix: only show valid fees for licences (dvsa/olcs-self…
1f7d376 
…serve#137)" (dvsa/olcs-selfserve#143)

This reverts commit 8295cc1b953b1fc213df3e41a29394b08776a795.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaLicense JoshuaLicense JoshuaLicense approved these changes

@jerotire jerotire jerotire left review comments

@fibble fibble fibble left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wadedvsa @JoshuaLicense @fibble @jerotire