This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
fix: Licence data service duplicated in service manager causing multi… #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple instances fixed.
…ple instances fixed.
JoshuaLicense
approved these changes
Jan 30, 2024
JoshuaLicense
deleted the
fix-licence-data-service-duplication-vol-4906
branch
jerotire
pushed a commit
to dvsa/vol-app
that referenced
this pull request
Aug 16, 2024
dvsa/olcs-internal#44) * fix: Licence data service duplicated in service manager causing multiple instances fixed. * fix: Licence data service duplicated in service manager causing multiple instances fixed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Licence Data Service was being instantiated twice, necessary context not being set on the instance used to populate the form select options.
Related issue: VOL-4906
Before submitting (or marking as "ready for review")