feat: ET-1441: add support for configurable maximum input and output token limits #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 21, 2023 13:46
…tokens in OpenAI API calls and update config keys and validation accordingly
…default values in README.md
…TOKENS_OUTPUT from config for calculating MAX_REQUEST_TOKENS value
vestron286
previously approved these changes
Nov 21, 2023
danwill89
reviewed
Nov 21, 2023
danwill89
previously approved these changes
Nov 21, 2023
…to OCO_TOKENS_MAX_OUTPUT
added 3 commits
November 22, 2023 12:58
…ngeLength is exceeded and improve code formatting in generateCommitMessageFromGitDiff.ts file
…adability and consistency
…in generateCommitMessageFromGitDiff
vestron286
reviewed
Nov 28, 2023
There was a problem hiding this comment.
Tested OCO on a range of inputs outputs.
With a MAX_INPUT of 4096:
- output 2048 -> works
- output 3072 -> works but small msg
- output 4054 -> never resolved, had to force quit through task manager
With a MAX_INPUT of 16384
- output 8192 -> Error 400
- output 4096 -> Works
…andling in generateCommitMessageFromGitDiff module
covolution
approved these changes
Nov 28, 2023
danwill89
approved these changes
Nov 28, 2023
mattsalt123
added a commit
that referenced
this pull request
Nov 29, 2023
…token limits (#6) * feat: ET-1441: add support for configurable maximum input and output tokens in OpenAI API calls and update config keys and validation accordingly * feat: ET-1441: update OCO_TOKENS_MAX_INPUT and OCO_TOKENS_MAX_OUTPUT default values in README.md * feat: ET-1441: update generateCommitMessageFromGitDiff.ts to use MAX_TOKENS_OUTPUT from config for calculating MAX_REQUEST_TOKENS value * feat: ET-1441: updated readme with correct config wording * fix: ET-1441: fix typo in variable name, change OCO_TOKENS_MAX_INPUT to OCO_TOKENS_MAX_OUTPUT * feat: ET-1441: add error handling for outputTokensTooHigh when maxChangeLength is exceeded and improve code formatting in generateCommitMessageFromGitDiff.ts file * fix: ET-1441: remove unnecessary space in the code to improve code readability and consistency * refactor: ET-1441: update README and error handling for token limits in generateCommitMessageFromGitDiff * refactor: ET-1441: refactor token limit constants and improve error handling in generateCommitMessageFromGitDiff module --------- Co-authored-by: Matthew Salter <[email protected]>
mattsalt123
added a commit
that referenced
this pull request
Nov 29, 2023
…token limits (#6) * feat: ET-1441: add support for configurable maximum input and output tokens in OpenAI API calls and update config keys and validation accordingly * feat: ET-1441: update OCO_TOKENS_MAX_INPUT and OCO_TOKENS_MAX_OUTPUT default values in README.md * feat: ET-1441: update generateCommitMessageFromGitDiff.ts to use MAX_TOKENS_OUTPUT from config for calculating MAX_REQUEST_TOKENS value * feat: ET-1441: updated readme with correct config wording * fix: ET-1441: fix typo in variable name, change OCO_TOKENS_MAX_INPUT to OCO_TOKENS_MAX_OUTPUT * feat: ET-1441: add error handling for outputTokensTooHigh when maxChangeLength is exceeded and improve code formatting in generateCommitMessageFromGitDiff.ts file * fix: ET-1441: remove unnecessary space in the code to improve code readability and consistency * refactor: ET-1441: update README and error handling for token limits in generateCommitMessageFromGitDiff * refactor: ET-1441: refactor token limit constants and improve error handling in generateCommitMessageFromGitDiff module --------- Co-authored-by: Matthew Salter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.