Skip to content

Commit

Permalink
ci: deprecate node 10
Browse files Browse the repository at this point in the history
  • Loading branch information
dvirtz committed Oct 22, 2021
1 parent 50a121c commit 3c37393
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:

strategy:
matrix:
node_version: [10.x, 12.x, 14.x]
node_version: [12.x, 14.x, 16.x]

steps:
- uses: actions/checkout@v2
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
"rollup-plugin-delete": "^2.0.0",
"rollup-plugin-node-globals": "^1.4.0",
"rollup-plugin-node-polyfills": "^0.2.1",
"semver": "^7.3.5",
"sinon": "^9.2.4",
"test-console": "^1.1.0"
},
Expand Down
3 changes: 2 additions & 1 deletion packages/reveal-test/test/consume.test.cjs
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
const { compile } = require('..');
const assert = require('assert');
const semver = require('semver');

describe('library consumer', function () {
it('can require the library', async function () {
await assert.rejects(compile, {
name: 'TypeError',
message: `Cannot read property 'failReason' of undefined`
message: semver.lt(process.version, '16.0.0') ? `Cannot read property 'failReason' of undefined` : `Cannot read properties of undefined (reading 'failReason')`
});
});
});
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6696,7 +6696,7 @@ semver@^6.0.0, semver@^6.1.2, semver@^6.2.0, semver@^6.3.0:
resolved "https://registry.yarnpkg.com/semver/-/semver-6.3.0.tgz#ee0a64c8af5e8ceea67687b133761e1becbd1d3d"
integrity sha512-b39TBaTSfV6yBrapU89p5fKekE2m/NwnDocOVruQFS1/veMgdzuPcnOM34M6CwxW8jH/lxEa5rBoDeUwu5HHTw==

semver@^7.3.2, semver@^7.3.4:
semver@^7.3.2, semver@^7.3.4, semver@^7.3.5:
version "7.3.5"
resolved "https://registry.yarnpkg.com/semver/-/semver-7.3.5.tgz#0b621c879348d8998e4b0e4be94b3f12e6018ef7"
integrity sha512-PoeGJYh8HK4BTO/a9Tf6ZG3veo/A7ZVsYrSA6J8ny9nb3B1VrpkuN+z9OE5wfE5p6H4LchYZsegiQgbJD94ZFQ==
Expand Down

0 comments on commit 3c37393

Please sign in to comment.