Avoid uninitialized scope prefix leading to UB on memcpy, though len …

…is 0
dvidelabs · Oct 23, 2023 · d533710 · d533710
1 parent aefd0c8
commit d533710
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -21,6 +21,7 @@
 - Fix regression where empty namespace in schema does not reset root scope
   correctly in parser (#265).
 - Fix lexer checks that breaks with UTF-8, notably UTF-8 schema comments (#267).
+- Fix UB in memcpy(p, 0, 0) by initializing scope prefix (mostly to silence sanitizers).
 
 ## [0.6.1]
 

diff --git a/src/compiler/parser.c b/src/compiler/parser.c
@@ -1430,6 +1430,8 @@ int fb_init_parser(fb_parser_t *P, fb_options_t *opts, const char *name,
     P->schema.name.name.s.s = s;
     P->schema.name.name.s.len = (int)n;
     checkmem((P->schema.errorname = fb_create_basename(name, name_len, "")));
+    P->schema.prefix.s = "";
+    P->schema.prefix.len = 0;
     if (opts->ns) {
         P->schema.prefix.s = (char *)opts->ns;
         P->schema.prefix.len = (int)strlen(opts->ns);