enables the use of per-request api-key/secret-key passing while keeping backward compatibility.

[fbettag]

I have used Application.set_env before, but this approach works a lot better.

feedback is welcome.

[fbettag]

gonna rewrite this again

[dvcrn]

I think you can inject those as extra optional parameters into optional_params, so they are becoming part of the keyword list opts: https://github.com/dvcrn/binance.ex/blob/master/lib/binance.ex#L74

Then inside client, check if those params exist, and if they do use them for overwriting the APplication.get_env stuff

Here's how I did it with a similar library (OpenAI):

https://github.com/dvcrn/ex_openai/blob/main/lib/ex_openai/client.ex#L117-L118

[fbettag]

thanks for the suggestion. currently running trials but iex -S mix looks good

[fbettag]

this now is nice and working. sorry for the fuzz

[dvcrn]

Thanks for the PR! I left some comments, mostly cosmetic

Also, I think we need a test for this. If you're unsure how to do it, I'm happy to help / take over as well.

[dvcrn]

The signature of this function is becoming a bit odd. API key should probably come after url, or in the end within optional args. Or even better - a pattern-matched function with different signature for apikey and no apikey

[dvcrn]

Same here

[dvcrn]

Yeah this is a bit odd

Probably better to make it a function with different signature or optional arg

[fbettag]

Since i really don't know how you like the functions to be, i'd appreciate it if you changed the 3 signatures to your liking :)

I wouldn't be mad if you take over from here, i don't wanna screw around in your awesome code more than needed, but as for the test i suggest using get_account_summary to test this out.

Also, big kudos for the code generator. I've used that part of the library to show off to clients how awesome Elixir can be. ;)

[fbettag]

actually trading (buy/sell) seems to be broken with this approach (worked with the other for some weird reason)

[dvcrn]

I've changed the function signatures and shuffled things around, then added a test

Could you give this branch a try? #107

[dvcrn]

Ping :)

[fbettag]

sorry i'm currently very busy with pre-christmas work -.- everyone needs stuff launched before christmas

[fbettag]

will try to get to it until the weekend

[fbettag]

hey dude,

sorry for the delay. so with this branch i get the following when trying to buy or sell:

{:binance_error, %{code: -1104, msg: "Not all sent parameters were read; read '5' parameter(s) but was sent '6'."}}

[dvcrn]

Thanks for the feedback

hrrrm, which method did you use? Can you post the code?

[fbettag]

 {:binance_error,
  %{
    code: -1104,
    msg: "Not all sent parameters were read; read '5' parameter(s) but was sent '6'."
  }}}
[error] [Strategy 2] -- Error placing sell order for 2.27 of SOLBTC at price market: {:binance_error, %{code: -1104, msg: "Not all sent parameters were read; read '5' parameter(s) but was sent '6'."}}

  def sell(api_key, secret_key, symbol, money, price \\ nil) do
    type = if price == nil, do: "MARKET", else: "LIMIT"
    opts = [qty: money, api_key: api_key, secret_key: secret_key]
    opts = if price != nil, do: Keyword.put(opts, :price, price), else: opts

    Binance.Trade.post_order(symbol, "SELL", type, opts)
    |> IO.inspect(label: "binance sell order")
  end

[fbettag]

ah damn now i see it, one second, that's actually my error. i just saw it by rereading the two things close together doooooh

Edit: nope this actually looks fine when dumping the params. had something else in my head apparently (sorry it's a saturday after having worked the past 3 weeks straight)

I also remember having this issue when i tried your approach. i have no idea how it triggers this issue.