Skip to content

Commit

Permalink
Rename api_secret -> secret_key for consistency
Browse files Browse the repository at this point in the history
  • Loading branch information
dvcrn committed Nov 3, 2023
1 parent d818353 commit 285ae32
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/binance.ex
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ docs
end)
|> Kernel.++([
%{name: "api_key", description: "Binance API key, will overwrite env key"},
%{name: "api_secret", description: "Binance API secret, will overwrite env secret"}
%{name: "secret_key", description: "Binance API secret, will overwrite env secret"}
])

optional_params =
Expand Down
2 changes: 1 addition & 1 deletion test/binance_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ defmodule BinanceTest do
use_cassette "get_open_orders_for_api_key_and_secret_key",
match_requests_on: [:headers, :request_body] do
assert {:error, {:binance_error, %{code: -2014, msg: "API-key format invalid."}}} =
Binance.Trade.get_open_orders(api_key: "dummy_api_key", api_secret: "hoge")
Binance.Trade.get_open_orders(api_key: "dummy_api_key", secret_key: "hoge")

Application.put_env(:binance, :api_key, "dummy_api_key")

Expand Down

0 comments on commit 285ae32

Please sign in to comment.