-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ember-cli 0.2.3 #81
ember-cli 0.2.3 #81
Conversation
Modify acceptance tests to return promises to force non-async execution; and various other updates.
66943b8
to
44b8fca
Compare
i submitted a PR quick fixes the issue #82 |
@benkonrath this should be good to merge |
@@ -9,7 +9,6 @@ | |||
/bower_components | |||
|
|||
# misc | |||
/.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use PyCharm so this ignore is useful for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix. I'll also add .travis.yml
while I'm at it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll merge this PR once you update this. Thanks.
Looks good. Thanks for the doing the work on this - there are some nice improvements of the tests and it's nice to see that things are still working with the new versions of ember and ember-data. I noticed you renamed the The README should also be updated to indicate that this adapter works with ember-cli 0.2.3, ember 1.11.1 and ember-data 1.0.0-beta.16.1. So it just the .gitignore and the question about the travis and then I'll merge it. |
"acceptance" tests seems to be the de facto terminology in Ember world. I'm indifferent in general, but would like to stay consistent with the ecosystem. |
- Ember 1.11.1 - Ember CLI 0.2.3 - Ember Data 1.0.0-beta.16.1
I think we're good here. |
This bumps our internal ember-cli to v0.2.3.
The PR is big as a lot needed updating. In summary: