Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "Cannot read property 'pkg' of null" error #8

Merged
merged 1 commit into from
Sep 27, 2014
Merged

Fix for "Cannot read property 'pkg' of null" error #8

merged 1 commit into from
Sep 27, 2014

Conversation

holandes22
Copy link
Collaborator

- The ember-cli-ember-data addon is deprecated
  switched the dependency to ember-data instead

Installed with npm from my local copy and it worked for me. I'm now being able to see "ember-data-django-rest-adapter" in info section of ember inspector

Not sure if it closes #6 as I wasn't able to reproduce this.

This means we now depend on ember-cli >= 0.4.5, but there are probably still issues with ember-data itself (1.0-BETA-10) and the adapter, so it's probably better to do a new release after this is done: toranb/ember-data-django-rest-adapter#101

    - The ember-cli-ember-data addon is deprecated
      switched the dependency to ember-data instead
@dustinfarris
Copy link
Owner

Looks good. Thanks!

dustinfarris pushed a commit that referenced this pull request Sep 27, 2014
Fix for "Cannot read property 'pkg' of null" error
@dustinfarris dustinfarris merged commit 5caf599 into dustinfarris:master Sep 27, 2014
@dustinfarris
Copy link
Owner

@holandes22, @benkonrath and I are working on porting over the code base for the adapter so we can align everything with latest ember and ember-cli and prepare for ember-data 1.0.

Feel free to idle #ember-django-adapter if you're interested.

@holandes22
Copy link
Collaborator Author

@dustinfarris I'm interested in ember-data 1.0 as well, so I'd like to help, do you have a branch for this? My Js skills are a little rust and I don't have much bandwidth but I might give a hand anyway.

I saw toranb/ember-data-django-rest-adapter#101 but not sure where is stucked

btw, I saw that several projects have the ember-cli addon hooks within the same repo, did you consider moving it over to the ember-data-django-rest-adapter repo?

@dustinfarris
Copy link
Owner

@holandes22 no branch. I'm going to release the change you just wrote, and then we will work on master to make this happen.

We are going to deprecate ember-data-django-adapter and move its code to this repo. Its repo owner (toranb) had to bow out so it makes sense to move it this way. That, and ember-django-adapter is shorter and easier to remember.

@holandes22
Copy link
Collaborator Author

I see, makes sense. I'm following the repo so I'll try to help once the migration is done.

I'm doing some preliminary tests in my project with @benkonrath PR, and seems to be working with latest beta of ED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addon not seen by ember-cli
2 participants