Move trailing slashes config #67
Conversation
Rather than making this an environment variable, make it a property of the adapter itself that can be easily configured by extending the adapter.
Move trailing slashes config
|
This means the next release will be 0.6.0, right? |
|
@benkonrath I'm not sure. Since the rewrite, it has been my intention to mimic ember-cli's versioning as much as possible—which is not exactly semver compliant. I think once we release 1.0.0, versioning will become much more important—and that won't happen until ED 1.0 is released and we've had a chance to battle test it. For now, I suppose 0.5 represents EDA post-rewrite, and I'd like to keep it at that minor version until 1.0, or when/if we feel like we've reached some other important milestone. What do you think? |
|
I guess semver gives us flexibility before 1.0.0 so I'm good with your proposal. In general I trust your intuition and judgment about when and how to do the releases. I was really just curious about how we would be proceeding. |
|
Ok, so let's call 0.6 a pre-ED-1.0 stable release of EDA—whenever we feel like we've addressed all of the major outstanding issues/bugs. |
The trailing slashes config isn't really something that changes between environments, so it shouldn't be configured as such.
This PR redefines how addTrailingSlashes is configured.
This is a breaking change.