Update ember and ember-data to 2.17. Fix deprecations. #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kolybasov thank you so much for this! You're right, CircleCI was running on a Ubuntu 12.04 image that doesn't come with yarn. I updated the setting to 14.04 (with yarn) and made a slight modification to circle.yml based on their docs. |
|
@dustinfarris thanks for the fix! Let me know if I need to made some changes to merge this. |
|
@kolybasov all good! really can't thank you enough for putting time into getting this done. 💙💙💙 will do a major version release since the supported versions of Ember have changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @dustinfarris! I did upgrade to addon with
ember-cli-update. Fixed deprecations. Could you test and merge it if all works well?Closes #205 and #206
UPD. Tests are passing locally but I am trying to fix them at CI.
UPD. @dustinfarris could you check CI settings please? Seems some very old image is used. Ping me so we can resolve issue together.