-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to enable Greenkeeper 🌴 #167
Conversation
Recent Ember does not support this. See: emberjs/ember.js#12457
37de244
to
daf629a
Compare
This PR upgrades ember-cli to 2.9.1 As part of the upgrade, I've had to remove unit tests that rely on stubbing calls to Also ember/ember-data <2.0 is no longer tested against. There were issues that seemed to be incompatibilities with test-support in latest ember-cli, and I don't really have time to work it out. Is anyone still using 1.13? None of the actual code has changed, so 1.13 should still be compatible, for now. If this is going to affect the community, I'd love a follow-up PR to make that work again and re-add 1.13 to ember-try. @benkonrath @holandes22 can one of you look this over and 👍 please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I browsed through this and it looks good. I didn't go into too much detail because a lot of the changes are from the update of ember-cli.
I still use 1.13 but I think we should just drop it (and even signal this change with a 2.0 release). People who use 1.13 can use the current version and if need be, we can make a 1.x branch for bug fixes and new 1.x point releases. I suspect there's little demand for this though.
It's a shame about the tests but there doesn't seem too much we can do about. It makes sense to just remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
I think it makes a lot of sense to drop support in a new release for 1.13 and focus more on LTS releases. If someone still needs to support 1.13 they can always use the previous version or maybe send a PR to bring back the support
As @benkonrath mentioned, this should be a major release, to mark clearly the drop in 1.13 support.
I'm sorry I don't have any helpful input about the tests removal or how to fix them, I'm quite rusty with this code.
ok, we'll do 2.0. thanks for the quick feedback guys |
Let’s get started with automated dependency management for ember-django-adapter 💪
This pull request updates all your dependencies to their latest version. Having them all up to date really is the best starting point. I will look out for further dependency updates and make sure to handle them in isolation and in real-time, as soon as you merge this pull request.
✅ If this pull request passes and everything is still working
This is really good news. Merge this pull request and I will keep you posted about dependency updates you shouldn’t miss.
❌ If this pull request fails and things aren’t working
Note: I won’t start sending you further updates, unless you have merged this very pull request.
So, how do we proceed? I suggest you find out what dependency update is causing the problem. Adapt your code so things are working nicely together again. next-update is a really handy tool to help you with this.
Push the changes to this branch and merge it.
In case you can not, or do not want to update a certain dependency right now, you can of course just change the
package.json
file back to your liking.Don’t forget to push your changes to this branch, and merge this pull request, so I can start sending you further updates.
How to update this pull request
How to ignore certain dependencies
Add a
greenkeeper.ignore
field to yourpackage.json
, containing a list of dependencies you don’t want to update right now.How the updates will look like
As soon as you merge this pull request I’ll create a branch for every dependency update, with the new version applied. The branch creation should trigger your testing services to check the new version. Using the results of these tests I’ll try to open meaningful and helpful pull requests and issues, so your dependencies remain working and up-to-date.
In the above example you can see an in-range update.
1.7.0
is included in the old^1.6.0
range, because of the caret^
character .When the test services report success I’ll delete the branch again, because no action needs to be taken – everything is fine.
When there is a failure however, I’ll create an issue so you know about the problem immediately.
This way every single version update of your dependencies will either continue to work with your project, or you’ll get to know of potential problems immediately.
In this example the new version
4.0.0
is not included in the old^3.0.0
range.For version updates like these – let’s call them “out of range” updates – you’ll receive a pull request.
Now you no longer need to check for exciting new versions by hand – I’ll just let you know automatically.
And the pull request will not only serve as a reminder to update. In case it passes your decent test suite that’s a strong reason to merge right away
Not sure how things are going to work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Good luck with your project and see you soon ✨
Your Greenkeeper Bot 🌴