Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coalesce Filter update docs regarding pagination. #145

Merged
merged 1 commit into from
Oct 23, 2015

Conversation

peec
Copy link
Contributor

@peec peec commented Oct 23, 2015

Disable pagination in example of Coalesce filter, see #144

Disable pagination in example of Coalesce filter, see dustinfarris#144
@benkonrath
Copy link
Collaborator

Great that you found a solution to your problem. Why do you recommend setting view.pagination_class = None on every request instead of setting it on the specific View that you want to have the pagination disabled?

@peec
Copy link
Contributor Author

peec commented Oct 23, 2015

ember-data will complain if it can't load related ids[]. So I think one would be better off handling this case at one place, as ember-data doesn't expect any pagination at all when trying to load records with given supplied ids[]. Pagination is only disabled when ids[] are supplied.

@benkonrath
Copy link
Collaborator

Ah ok, I understand. You want to be able to use the view as a regular paginated view and only disable pagination when it's an ember-data request with ids[]. Looks good to me.

@dustinfarris Any thoughts?

@dustinfarris
Copy link
Owner

I think this makes perfect sense. I'm glad the solution is simple. Thanks for sorting this out, @peec.

dustinfarris added a commit that referenced this pull request Oct 23, 2015
Coalesce Filter  update docs regarding pagination.
@dustinfarris dustinfarris merged commit 2601222 into dustinfarris:master Oct 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants