Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to rest serializer #133

Merged

Conversation

benkonrath
Copy link
Collaborator

This is ready to go. except that I would like to get confirmation that this in fact fixes #132.

Edit: Let's deal with #132 separately.

Fixes #128
Fixes #130

@hoIIer
Copy link

hoIIer commented Aug 28, 2015

@benkonrath

_this.store.pushPayload('user', response)
store.js:1851 Uncaught TypeError: serializer.pushPayload is not a function

@hoIIer
Copy link

hoIIer commented Aug 28, 2015

message: "Assertion Failed: You cannot usestore#pushPayloadwithout a modelName unless your default serializer definespushPayload"

@hoIIer
Copy link

hoIIer commented Aug 28, 2015

in console it does show _this.store.pushPayload so it may just be that Im not invoking it correctly (followed ember DS.store doc)..

@dustinfarris
Copy link
Owner

@erichonkanen try:

let data = _this.store.normalize('user', response);
_this.store.pushPayload('user', data);

@rinti
Copy link

rinti commented Aug 31, 2015

@benkonrath @dustinfarris I just ran in to (almost) the #128 problem, and this patch fixed it for me.

@dustinfarris
Copy link
Owner

@erichonkanen any update?

@benkonrath
Copy link
Collaborator Author

@dustinfarris Let's just deal with #132 separately if it still needs to be addressed.

dustinfarris added a commit that referenced this pull request Aug 31, 2015
@dustinfarris dustinfarris merged commit 0929f98 into dustinfarris:master Aug 31, 2015
@benkonrath
Copy link
Collaborator Author

@dustinfarris What do you think about cutting a new release? Maybe 1.1?

@dustinfarris
Copy link
Owner

@benkonrath Yes, i just sent you a DM on Twitter. 1.1 sounds fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serializer.pushPayload is not a function store.queryRecord error
4 participants