Remove bit_iterator macro
#719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems one of the CI checks failed due to an error in uploading a coverage report to codecov. |
moCello
requested changes
Jan 18, 2023
There was a problem hiding this comment.
Very nice, thanks!
Please also include the Debug, Clone and Copy traits as mentioned in the comments.
And it would be great if you could also add a section in the CHANGELOG under 'Unreleased', like:
Removed
- Remove
bit_iteratormacro [Removebit_iteratormacro #632]
And link the issue at the bottom of the CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #632