Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator - Extended point #31

Closed
vlopes11 opened this issue Aug 11, 2020 · 2 comments
Closed

Generator - Extended point #31

vlopes11 opened this issue Aug 11, 2020 · 2 comments
Assignees
Labels
type:feature implementing a new feature

Comments

@vlopes11
Copy link

vlopes11 commented Aug 11, 2020

Most of the operations are performed with ExtendedPoint instead of AffinePoint, but only a generator in the affine form is available.

Create a constant GENERATOR_EXTENDED that will be a GENERATOR converted to Extended

This way the users of the API won't be obliged to do so.

pub const GENERATOR_EXTENDED: ExtendedPoint = ExtendedPoint {
    x: Fq::from_raw([
        0x4df7b7ffec7beaca,
        0x2e3ebb21fd6c54ed,
        0xf1fbf02d0fd6cce6,
        0x3fd2814c43ac65a6,
    ]),
    y: Fq::from_raw([
        0x0000000000000012,
        000000000000000000,
        000000000000000000,
        000000000000,
    ]),
    z: Fq::one(),
    t1: Fq::from_raw([
        0x4df7b7ffec7beaca,
        0x2e3ebb21fd6c54ed,
        0xf1fbf02d0fd6cce6,
        0x3fd2814c43ac65a6,
    ]),
    t2: Fq::from_raw([
        0x0000000000000012,
        000000000000000000,
        000000000000000000,
        000000000000,
    ]),
};
@CPerezz CPerezz added the type:feature implementing a new feature label Aug 11, 2020
@CPerezz
Copy link

CPerezz commented Aug 12, 2020

My suggestion would be to also implement GENERATOR_NUMS also @vlopes11

vlopes11 added a commit that referenced this issue Aug 12, 2020
Every in-memory operation is performed with extended points, so the user
of the API will always need to convert the Affine Points to extend
before performing the operations.

To facilitate, we made available by default the generators also in
extended form.
vlopes11 added a commit that referenced this issue Aug 13, 2020
Implements #31 - Generators available as extended
@vlopes11 vlopes11 mentioned this issue Aug 13, 2020
@CPerezz
Copy link

CPerezz commented Aug 13, 2020

Closed via #34

@CPerezz CPerezz closed this as completed Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature implementing a new feature
Projects
None yet
Development

No branches or pull requests

2 participants