Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shellsafe returns unsafe chars in 0.0.11 #18

Closed
wants to merge 1 commit into from
Closed

shellsafe returns unsafe chars in 0.0.11 #18

wants to merge 1 commit into from

Conversation

asquelt
Copy link
Contributor

@asquelt asquelt commented Dec 22, 2014

chars method was called before shellsafe method and @chars were initialized with characters which should never appear in shell. please issue 0.0.12 as this might be security related.

debug with print on charsets methods:

CHARS
SHELLSAFE
ALPHA
ALPHA
SHELLSAFE
CHARSET shellsafe ["a", "b", "c", "d", "e", "f", "g", "h", "i", "j", "k", "l", "m", "n", "o", "p", "q", "r", "s", "t", "u", "v", "w", "x", "y", "z", "A", "B", "C", "D", "E", "F", "G", "H", "I", "J", "K", "L", "M", "N", "O", "P", "Q", "R", "S", "T", "U", "V", "W", "X", "Y", "Z", "0", "1", "2", "3", "4", "5", "6", "7", "8", "9", "+", "%", "/", "@", "=", "?", "_", ".", ",", ":", "*", "(", ")", "&", "!", "[", "]", "{", "}", "-"]
QR&AbAKSR=%9c{,+-N,0JD/6{=hxe!wZ9
QR&AbAKSR=%9c{,+-N,0JD/6{=hxe!wZ9

@asquelt
Copy link
Contributor Author

asquelt commented Dec 22, 2014

sorry, patched wrong version...

@asquelt
Copy link
Contributor Author

asquelt commented Dec 22, 2014

corrected in #19

@asquelt asquelt closed this Dec 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant