Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Puppet8x support #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

flepoutre
Copy link

No description provided.

owner => $edit_uid,
group => 0,
mode => '0600',
require => Package['trocla'];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the idea to use the collector is that the collector can also be empty since there might be cases where you do not have the package installed.

}
}
Package<| title == 'trocla' |> -> file {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here with the collector

r = has_options ? store.send(trocla_func, key, format, options) : store.send(trocla_func, key, format)
store.close
r
# Functions called from puppet manifests that look like this:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for the change in indentation?

@duritong
Copy link
Owner

Thank you, much appreciated!

The collector statement is imho still necessary and it is still supported: https://www.puppet.com/docs/puppet/8/lang_collectors.html

And other than that it would be greate to at least split the indentation changes into their own commit, since this makes it not so clear what are required changes for puppet 8 and what is (debatable) cosmetic changes. Any chance to get that at least splitted?

@flepoutre
Copy link
Author

The changes for Puppet8 mainly concern variable typing and legacy facts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants