crypto: use RustCrypto utils over deprecated rust-crypto #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change started due to my unfortunate exposure to a bug impacting the ability for my project to target aarch64: DaGenix/rust-crypto#383. In that issue (and in others) it is clear that rust-crypto is now deprecated in favor of the RustCrypto crates (here we need sha2/hmac). This change drops in this replacement for rust-crypto. Signed-off-by: Paul Osborne <[email protected]>
|
Pretty straight forward - LGTM |
|
@durch I believe @nastevens has another larger change currently gated on this one that will be opened once this is merged if you can take a look. That second change will remove the curl dependency which was giving us fits for some of our work on some embedded platforms. |
|
@posborne thanks for this :), merged, and will be published to crates.io in a few minutes |
|
@posborne, @nastevens published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change started due to my unfortunate exposure to a bug impacting
the ability for my project to target aarch64:
DaGenix/rust-crypto#383.
In that issue (and in others) it is clear that rust-crypto is now
deprecated in favor of the RustCrypto crates (here we need sha2/hmac).
This change drops in this replacement for rust-crypto.
CC @nastevens