Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target Java 17 #65

Merged
merged 10 commits into from
Oct 27, 2023
Merged

Target Java 17 #65

merged 10 commits into from
Oct 27, 2023

Conversation

mikejritter
Copy link
Contributor

Various updates to get compilation working on java 17

  • Update compiler target
  • Update easymock, ehcache, commons-lang3 dependencies
  • Update ehcache usage for new version
  • Fix package for imports in Morsel
  • Disable selenium tests

I think the ehcache updates are equivalent to the old configuration. The Iterators changes comes from ehcache.xml which can be removed. It also looks like that class might be able to be removed -- it's only used by IteratorsTest so I'm not sure what it was for.

The update in the loopingduptaskproducer AppDriver I think is ok, but should be tested more thoroughly.

I disabled the selenium tests, we'll need to look into updating that both here and in duracloud.

@dbernstein

@dbernstein
Copy link
Member

This looks good but I believe you'll need to add b3c0129 (Java 17 in the docker file) for the containers to run properly.

Copy link
Member

@dbernstein dbernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DockerFile needs to be update with Java 17.

@dbernstein dbernstein merged commit 55fe0d2 into duracloud:develop Oct 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants