I added entries from my Nordic adblock list #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I noticed your list, and figured you'd want some more anti-shoddy-webstore entries.
Although my own list categorises anti-shoddy-webstore, anti-fake-giftcard, and anti-Bitcoin-scam entries more or less together, I tried my best to only submit the anti-shoddy-webstore entries among them.
! ————————————————————————
I also hereby propose that an adblocker- and AdGuard Home-specific version of this list gets generated from the raw list version, as this would mean that having separate entries for
www.
and non-.www
domains wouldn't be necessary, nor would it be needed to add various prefix domains either. A RegEx conversion process would nominally be as simple as:^0.* (www|store)\..*\n
→ (empty)^0.* (www|store)\..*
→ (empty)^0.* (.*)
→||\1^
I couldn't find the list generation script you're using in this repo, so I'll have to leave it up to you to generate such a list version should you wish to accept my proposal. If such a list does get created, I'll give such a list warm recommendations for native inclusion in stock installations of AdGuard Home, who are currently doing rollcalls for new lists to add, especially so if they're AdGuard Home-tailored.