Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I added entries from my Nordic adblock list #1

Merged
merged 2 commits into from
Jan 29, 2020

Conversation

DandelionSprout
Copy link
Contributor

@DandelionSprout DandelionSprout commented Jan 11, 2020

Hello. I noticed your list, and figured you'd want some more anti-shoddy-webstore entries.

Although my own list categorises anti-shoddy-webstore, anti-fake-giftcard, and anti-Bitcoin-scam entries more or less together, I tried my best to only submit the anti-shoddy-webstore entries among them.

! ————————————————————————

I also hereby propose that an adblocker- and AdGuard Home-specific version of this list gets generated from the raw list version, as this would mean that having separate entries for www. and non-.www domains wouldn't be necessary, nor would it be needed to add various prefix domains either. A RegEx conversion process would nominally be as simple as:

  1. ^0.* (www|store)\..*\n → (empty)
  2. ^0.* (www|store)\..* → (empty)
  3. ^0.* (.*)||\1^

I couldn't find the list generation script you're using in this repo, so I'll have to leave it up to you to generate such a list version should you wish to accept my proposal. If such a list does get created, I'll give such a list warm recommendations for native inclusion in stock installations of AdGuard Home, who are currently doing rollcalls for new lists to add, especially so if they're AdGuard Home-tailored.

@durablenapkin durablenapkin merged commit 1754a1e into durablenapkin:master Jan 29, 2020
@durablenapkin
Copy link
Owner

Many thanks! Will look into creating a script to generate an Adguard compatible list with just domains (no prefixes).

@durablenapkin durablenapkin self-assigned this Jan 29, 2020
@durablenapkin
Copy link
Owner

@DandelionSprout AdGuard compatible list can be found here: https://raw.githubusercontent.com/durablenapkin/scamblocklist/master/adguard.txt (dead hosts removed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants