Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notion page search support #13

Merged
merged 7 commits into from
May 15, 2021
Merged

Add Notion page search support #13

merged 7 commits into from
May 15, 2021

Conversation

spacephoton
Copy link
Contributor

image

Caveats:

  • Notion API sometimes returns duplicate results when query matches several properties (such as url + title).
  • Only included page results because not clear how to create urls from the database results, and users are more likely to search for pages within the database anyway.
  • Did not include content preview, which could be fetched with the block children api. Page contents may not contain the search query since search API is searches through page titles and properties.

Copy link
Member

@artnc artnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great!

@artnc artnc merged commit ff5ee55 into duolingo:master May 15, 2021
@artnc artnc mentioned this pull request Jun 14, 2021
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants