Add BitBucket support

[stephenmathieson]

• separate github stuff from main api
• add primitive "providers" (github, bitbucket)
• simple test case proving bitbucket support works

this is really just to get a code review. ideally, we'd move the provider modules into their own respective repos, but i didn't want to start creating duo-* without some feedback.

[yields]

nice!

[matthewmueller]

Hmm... I wonder if auth should be a function, just like resolve and tarball. what do you think?

[stephenmathieson]

yeah, that makes sense for consistency sake.

[matthewmueller]

thanks @stephenmathieson!

I think this is getting pretty close. I'm not sure I like how resolve is the only thing that requires a callback function. auth and tarball are basically read-only values (though one is a function one is not) while resolve does a bunch of provider-specific work. I think we could organize this into something a bit cleaner.

Maybe this is just the way the problem ends up unfolding, but I'm not quite sold yet on this implementation as it stands.

[matthewmueller]

So basically right now the API looks like:

provider.auth
provider.tarball(repo, ref)
provider.resolve(repo, ref, fn)

I think if this is only going to work for duo, we might be able to get away with:

provider.auth()
provider.tarball(repo, ref)
*provider.resolve(repo, ref)

but even then, i don't like how one function is doing pretty much all the work... could we just have bb-resolve and gh-resolve or do we need the other stuff?

[stephenmathieson]

could we just have bb-resolve and gh-resolve or do we need the other stuff?

yes and no. the resolve stuff is the majority of the work, but the tarball endpoints will differ from provider-to-provider:

• github: https://<auth>github.com/<owner>/<repo>/archive/<ref>.tar.gz
• bitbucket: https://<auth>bitbucket.org/<owner>/<repo>/get/<ref>.tar.gz
• npm: http://registry.npmjs.org/<repo>/-/<repo>-<ref>.tgz

*provider.resolve(repo, ref)

yeah, i agree. i'm already calling thunkify(provider.resolve), but thats pretty hacky. ill refactor in a bit.

[stephenmathieson]

@matthewmueller pushed some new commits and:

• .resolve() is now a generator
• .auth() is now a function

[dominicbarnes]

Is there any reason this isn't being merged? (don't want it to grow stale, it is a nice step forward)

[stephenmathieson]

@dominicbarnes iirc, stability/ready for being open sourced > bitbucket

[matthewmueller]

Yah, I want to merge this, but I'm not sure now is the right time :-/

[matthewmueller]

After Duo is out and we're more stable (travis, coveralls, etc.) I'll feel more comfortable introducing big new features.

[stryju]

any progress on that? :)

[matthewmueller]

I should have merged this at the time, just came right as we were gearing up to release. I'd be down to merge this now if we can update it.

[stephenmathieson]

@matthewmueller i've got a private fork with bitbucket support, but it's severely out of date with everything. i'll try to get something together soonish though.

[stephenmathieson]

is the proposed api here still acceptable btw?

/cc @dominicbarnes @matthewmueller @yields

[dominicbarnes]

+1 from me, would really like to see a big step forward like this