Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.8, add 3.12, 3.13 support #233

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Conversation

ds-cbo
Copy link
Contributor

@ds-cbo ds-cbo commented Nov 21, 2024

Updating tests to cover all currently supported python versions

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024

CLA assistant check
All committers have signed the CLA.

@ds-cbo
Copy link
Contributor Author

ds-cbo commented Nov 21, 2024

Ah, python 3.13 is still too far ahead for pyo3 (sub-dependency through cryptography) for now, but it seems to be close to done: PyO3/pyo3#4265

Update: Actually, that wasn't the issue, support was already added in existing versions, we just need to bump our dependencies

Copy link
Collaborator

@MasterKale MasterKale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ds-cbo Thank you for taking this work on, this all looks good to me. And thanks for the timeline link 👀

@MasterKale MasterKale merged commit 067db09 into duo-labs:master Nov 21, 2024
5 checks passed
@MasterKale
Copy link
Collaborator

@ds-cbo These changes have gone out as webauthn==2.3.0 now available on PyPI https://pypi.org/project/webauthn/2.3.0/

@ds-cbo
Copy link
Contributor Author

ds-cbo commented Nov 22, 2024

@MasterKale Thanks! Happy to help

@ds-cbo ds-cbo deleted the patch-1 branch November 22, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants