Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle correctly file uri icons #1409

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Handle correctly file uri icons #1409

merged 3 commits into from
Dec 10, 2024

Conversation

bynect
Copy link
Member

@bynect bynect commented Dec 9, 2024

Came up in #1408

@bynect bynect requested review from fwsmit and zappolowski December 9, 2024 00:53
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.12%. Comparing base (162fc27) to head (e28a74c).

Files with missing lines Patch % Lines
src/icon.c 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1409   +/-   ##
=======================================
  Coverage   65.12%   65.12%           
=======================================
  Files          50       50           
  Lines        8654     8652    -2     
  Branches     1023     1023           
=======================================
- Hits         5636     5635    -1     
+ Misses       3018     3017    -1     
Flag Coverage Δ
unittests 65.12% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bynect bynect merged commit 5149aa7 into dunst-project:master Dec 10, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants