Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for custom docker image #75

Merged
merged 3 commits into from
Nov 3, 2022

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Oct 31, 2022

I'm missing something like this in the docs.

@dunglas
Copy link
Owner

dunglas commented Oct 31, 2022

Can't we merge this with the existing docs about Docker in a "Docker" section?

@alexander-schranz
Copy link
Contributor Author

alexander-schranz commented Oct 31, 2022

@dunglas Yeah I was not sure to mix them up. I think the currenlty docker.md is focused for Contributers or Maintaincers of FrankenPHP not about the one using it.

I even think worker.md linked as The worker mode is misleading and should be called Getting Started instead or Using FrankenPHP and then maybe add it there?

Also I personally more a fan to have one bigger doc file instead of splitting the docs into multiple files make searching for specific things easier and think why also Symfony merged a lot of docs together in the last years.

What do you think?

@back-2-95
Copy link
Contributor

I was also thinking about docs like this. But this is really different thing than the current content of docker.md.

Maybe something like "Extending FrankenPHP" ?

@dunglas
Copy link
Owner

dunglas commented Nov 1, 2022

Or just a new section at the end: "Creating Your Own Images"?

@dunglas dunglas force-pushed the feature/custom-docker-image branch from 3829518 to 9792240 Compare November 3, 2022 07:53
@dunglas dunglas force-pushed the feature/custom-docker-image branch from 42b6bbf to 06d7796 Compare November 3, 2022 08:03
@dunglas dunglas merged commit 3641552 into dunglas:main Nov 3, 2022
@dunglas
Copy link
Owner

dunglas commented Nov 3, 2022

Thank you @alexander-schranz!!

@alexander-schranz alexander-schranz deleted the feature/custom-docker-image branch November 3, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants