Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore watcher dir creation error if the watcher exists #1165

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

bk-ty
Copy link
Contributor

@bk-ty bk-ty commented Nov 14, 2024

Docker presented the error when building on linux/arm64. Applying the -p flag to mkdir allowed for successful builds.

0.324 + curlGitHubHeaders=(--header "X-GitHub-Api-Version: 2022-11-28")
0.324 + '[' '' ']'
0.324 + mkdir watcher
0.324 mkdir: can't create directory 'watcher': File exists

@bk-ty bk-ty changed the title Ignore watcher dir creation error if the watcher exists fix: Ignore watcher dir creation error if the watcher exists Nov 14, 2024
@dunglas dunglas merged commit a441e22 into dunglas:main Nov 14, 2024
31 checks passed
@dunglas
Copy link
Owner

dunglas commented Nov 14, 2024

Thanks!

@wayanjimmy
Copy link

@dunglas is this fix included in 1.3.1 ?

@AlliBalliBaba
Copy link
Collaborator

Hmm I don't think it is in 1.3.1 yet, in the meantime you can add an rm -r at the end of the static-build.Dockerfile like this:

# Build the static binary
WORKDIR /go/src/app/
RUN rm -r dist/static-php-cli/watcher
RUN EMBED=dist/app/ ./build-static.sh

@wayanjimmy
Copy link

nice idea thanks @AlliBalliBaba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants