Add TwoPhaseKnnVectorQuery #29
Open
+248
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dungba88
force-pushed
the
two-phase-vector
branch
from
dd8f079 to
96d2987
Compare
dungba88
force-pushed
the
two-phase-vector
branch
from
cf3e558 to
a06f980
Compare
dungba88
force-pushed
the
two-phase-vector
branch
from
a06f980 to
e2ab4bc
Compare
dungba88
force-pushed
the
two-phase-vector
branch
from
33c5fcd to
ccd3e25
Compare
benwtrent
reviewed
Nov 20, 2024
| * | ||
| * @lucene.experimental | ||
| */ | ||
| public class TwoPhaseKnnVectorQuery extends KnnFloatVectorQuery { |
There was a problem hiding this comment.
I think we would need a brand new query that doesn't build on top of AbstractKnnVectorQuery. Instead, gets passed the desired knn query as a parameter & the desired target then the outer reranking query can call the knn query via rewrite.
There was a problem hiding this comment.
Oh that's a cleaner idea actually. Let me try it in next rev.
huynmg
reviewed
Nov 21, 2024
Comment on lines
71
to
78
| for (int i = 0; i < NUM_VECTORS; i++) { | ||
| float[] vector = randomFloatVector(VECTOR_DIMENSION, random); | ||
| Document doc = new Document(); | ||
| doc.add(new IntField("id", i, Field.Store.YES)); | ||
| doc.add(new KnnFloatVectorField(FIELD, vector, VECTOR_SIMILARITY_FUNCTION)); | ||
| writer.addDocument(doc); | ||
| vectors.put(i, vector); | ||
| } |
There was a problem hiding this comment.
Maybe we should flush the writers a few time to create more than one segments, this make sure the code path that results are merged from multiple segments are executed.
There was a problem hiding this comment.
Good points, I added the flush() and uncovered/fixed a bug with doc ord.
dungba88
force-pushed
the
two-phase-vector
branch
from
d9f331f to
8cd3ccf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Draft for two-phase vector search (see apache#13564). Created a new Query for sake of simplicity.