-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Solana gas fees model #6926
Conversation
…s/spellbook into add_solana_gas_fees
This reverts commit b3c8b7a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent
logic checks pass and I think I caught all edgecases now. |
the incremental build spits out errors because it doesn't have prices for the most recent transactions, could hard limit to some 30 minute delay or smth cut-off date |
will open up non-incremental to a month now to see how that changes runtimes |
looks good to me.
we can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me, I don't see any further reasons why incremental is taking longer.
also don't have anything more to change here, should be good to merge |
before merging we need to take out all |
agreed on setup looking good. can't help but wonder how much incremental time increases when history is expanded extensively (larger table to lookup on in merge). this is only on 10 days of history? oof. will require us to watch first run after merge + next few incremental to see how it's looking for sure |
This incremental predicate should keep it from getting slower though. The amount of hashes to merge into should stay roughly static if this limits the range of hashes to compare against.
|
oh yes, of course, should be good |
i wonder if our issue on incremental could be around on evm raw tables, they are views where here we set |
reasonable hypothesis - can we change no way to loose the connection that way |
doesn't hurt to give it a shot. we could also update the source incremental filters to match the updated target one |
I'll run some tests to see |
ok, this is as optimized as we can get it. I guess it's just the raw amount of rows that is causing the incremental to take so long :( |
This PR adds the Solana gas fees model, excluding source and documentation parts.