Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query and doc fixes for first_funded_by + add a few columns #6923

Merged
merged 6 commits into from
Oct 11, 2024

Conversation

hildobby
Copy link
Collaborator

@hildobby hildobby commented Oct 10, 2024

This PR:

  • fixes some documentation issues given that not all native tokens are ETH
  • fixes some query issues not factoring in trace_address, an essential inclusion for txs funding multiple addresses
  • added token_symbol, trace_address, amount and amount_usd to the crosschain spell:
    • token_symbol is necessary given not all EVM chains use ETH as their native currency
    • trace_address is must to easily and efficiently join this spell onto other spells and remain accurate
    • amount & amount_usd are very useful for sleuthing stuff like CEX deposit addresses (they're usually funded in tiny amounts of native token)

@hildobby hildobby added the WIP work in progress label Oct 10, 2024
@hildobby hildobby added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Oct 11, 2024
@jeff-dude jeff-dude self-assigned this Oct 11, 2024
@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR question Further information is requested and removed ready-for-review this PR development is complete, please review labels Oct 11, 2024
@jeff-dude
Copy link
Member

can you help validate if these seed errors are real?

@hildobby
Copy link
Collaborator Author

hildobby commented Oct 11, 2024

can you help validate if these seed errors are real?

those errors are to be expected with a restricted time range (which doesnt start at chain inception). some addresses were funded before the date filter but the spell can't see that here, hence the errors, removing the filter will have tests passing

@jeff-dude jeff-dude removed question Further information is requested in review Assignee is currently reviewing the PR labels Oct 11, 2024
@jeff-dude jeff-dude merged commit 97c87d5 into duneanalytics:main Oct 11, 2024
1 of 2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants