-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch to add compound v3 Base asset supply #6448
Conversation
Workflow run id 10124569609 approved. |
Workflow run id 10124569776 approved. |
Workflow run id 10124648355 approved. |
Workflow run id 10124648407 approved. |
Workflow run id 10124683511 approved. |
Workflow run id 10124683623 approved. |
Workflow run id 10125647785 approved. |
Workflow run id 10125647879 approved. |
Workflow run id 10130001623 approved. |
Workflow run id 10130001662 approved. |
Workflow run id 10131245095 approved. |
Workflow run id 10131245322 approved. |
Workflow run id 10131294548 approved. |
Workflow run id 10131294663 approved. |
Workflow run id 10149989285 approved. |
Workflow run id 10149989536 approved. |
Workflow run id 10149989545 approved. |
Workflow run id 10150451695 approved. |
Workflow run id 10150451912 approved. |
Workflow run id 10150451913 approved. |
Workflow run id 10150605544 approved. |
Workflow run id 10150605695 approved. |
Workflow run id 10150605721 approved. |
Workflow run id 10150698778 approved. |
Workflow run id 10150699116 approved. |
Workflow run id 10150699125 approved. |
Workflow run id 10150763242 approved. |
Workflow run id 10150763383 approved. |
Workflow run id 10150763384 approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.✅
Thank you @darvinrio
from what i can gather, #6495 includes both borrow & supply, so i will close this PR. plz take a moment to review that PR again and ensure all is good. |
Thank you for contributing to Spellbook 🪄
Update!
Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.
Contribution type
Please check the type of contribution this pull request is for:
Note: You can safely discard any section below which doesn't apply based on selection above
For adding to existing spell lineage
If you are adding to an existing spell lineage, please provide the following information:
Description: [Description of the changes made]
Adding Supply and withdraw events of Base asset of compound v3 pools.
for withdraws and borrows check -> https://dune.com/queries/3945443
for supply and repay check -> https://dune.com/queries/3945395
WIP
TODO : add borrow and repays next
Thank you for your contribution!