Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maverick v2 to dex.trades spell #6406

Merged
merged 19 commits into from
Jul 25, 2024

Conversation

gte620v
Copy link
Contributor

@gte620v gte620v commented Jul 22, 2024

Thank you for contributing to Spellbook 🪄

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: Adding maverick v2 dex.trade spells. There is only a small difference in the event format of maverick v1.

@gte620v gte620v marked this pull request as draft July 22, 2024 20:28
@dune-eng
Copy link

Workflow run id 10047896073 approved.

@dune-eng
Copy link

Workflow run id 10047896368 approved.

@dune-eng
Copy link

Workflow run id 10047896381 approved.

@dune-eng
Copy link

Workflow run id 10048091191 approved.

@dune-eng
Copy link

Workflow run id 10048091382 approved.

@dune-eng
Copy link

Workflow run id 10048091381 approved.

@dune-eng
Copy link

Workflow run id 10048114860 approved.

@dune-eng
Copy link

Workflow run id 10048115155 approved.

@dune-eng
Copy link

Workflow run id 10048115161 approved.

@dune-eng
Copy link

Workflow run id 10049725636 approved.

@dune-eng
Copy link

Workflow run id 10049725923 approved.

@dune-eng
Copy link

Workflow run id 10049725933 approved.

@dune-eng
Copy link

Workflow run id 10049782086 approved.

@dune-eng
Copy link

Workflow run id 10049782253 approved.

@dune-eng
Copy link

Workflow run id 10049782247 approved.

@dune-eng
Copy link

Workflow run id 10049921577 approved.

@dune-eng
Copy link

Workflow run id 10049921845 approved.

@dune-eng
Copy link

Workflow run id 10049921791 approved.

@dune-eng
Copy link

Workflow run id 10049921817 approved.

@dune-eng
Copy link

Workflow run id 10049965692 approved.

@dune-eng
Copy link

Workflow run id 10049965877 approved.

@dune-eng
Copy link

Workflow run id 10049965898 approved.

Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @gte620v

@Hosuke Hosuke added dbt: dex covers the DEX dbt subproject ready-for-final-review and removed in review Assignee is currently reviewing the PR labels Jul 25, 2024
@Hosuke Hosuke assigned jeff-dude and unassigned Hosuke Jul 25, 2024
@jeff-dude
Copy link
Member

we are blocked by merge conflicts, without access to help resolve

@gte620v
Copy link
Contributor Author

gte620v commented Jul 25, 2024

we are blocked by merge conflicts, without access to help resolve

try now

@dune-eng
Copy link

Workflow run id 10101625856 approved.

@dune-eng
Copy link

Workflow run id 10101626130 approved.

@dune-eng
Copy link

Workflow run id 10101626111 approved.

@dune-eng
Copy link

Workflow run id 10101626143 approved.

@dune-eng
Copy link

Workflow run id 10101626144 approved.

@dune-eng
Copy link

Workflow run id 10101672101 approved.

@dune-eng
Copy link

Workflow run id 10101672299 approved.

@dune-eng
Copy link

Workflow run id 10101672273 approved.

@dune-eng
Copy link

Workflow run id 10101672305 approved.

@dune-eng
Copy link

Workflow run id 10101672304 approved.

@jeff-dude
Copy link
Member

thank you, let's see CI pass to be safe

@jeff-dude jeff-dude removed the blocked label Jul 25, 2024
@jeff-dude jeff-dude merged commit f85cf40 into duneanalytics:main Jul 25, 2024
5 checks passed
Copy link

gitpoap-bot bot commented Jul 25, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Dune Contributor:

GitPOAP: 2024 Dune Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants