Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Safe on Ethereum Balances #6392

Merged
merged 22 commits into from
Aug 2, 2024
Merged

Conversation

safeintern
Copy link
Contributor

@safeintern safeintern commented Jul 19, 2024

Thank you for contributing to Spellbook 🪄

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s): schema.table_name
  • Description: [Detailed description of the new spell(s) and their purpose]
  • Who are the new spell(s) for? [Internal team or general community]
  • How will the new spell(s) be used downstream? [Description of downstream usage]
  • Implementation details: [Information on how the spell(s) are implemented]
  • Test instructions: [How to test the new spell(s)]
  • Related issue(s): [Link to related issues, if any]

For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: [Description of the changes made]

For bug fixes

If you are fixing a bug, please provide the following information:

  • Description: [Description of the bug fix]
  • Steps to reproduce: [How to reproduce the bug]
  • Implementation details: [Information on how the bug was fixed]
  • Test instructions: [How to test the fix]
  • Related issue(s): [Link to related issues, if any]

Additional information

Please provide any additional information that might help us review your pull request:

  • [Any additional information]

Thank you for your contribution!

@dune-eng
Copy link

Workflow run id 10005575837 approved.

@dune-eng
Copy link

Workflow run id 10005576029 approved.

@jeff-dude jeff-dude added the WIP work in progress label Jul 19, 2024
@dune-eng
Copy link

Workflow run id 10029444725 approved.

@dune-eng
Copy link

Workflow run id 10029444779 approved.

@dune-eng
Copy link

Workflow run id 10029532940 approved.

@dune-eng
Copy link

Workflow run id 10029533067 approved.

@dune-eng
Copy link

Workflow run id 10039945491 approved.

@dune-eng
Copy link

Workflow run id 10039945661 approved.

@dune-eng
Copy link

Workflow run id 10039977807 approved.

@dune-eng
Copy link

Workflow run id 10039978023 approved.

@dune-eng
Copy link

Workflow run id 10040029584 approved.

@dune-eng
Copy link

Workflow run id 10040029443 approved.

Added token balance
@dune-eng
Copy link

Workflow run id 10042220946 approved.

@dune-eng
Copy link

Workflow run id 10042221522 approved.

@safeintern
Copy link
Contributor Author

@jeff-dude what am I missing here?

@jeff-dude
Copy link
Member

@jeff-dude what am I missing here?

looks like the error only appears on incremental run, and only one block of incremental code in the model. i'm not sure why the engine is throwing that generic error, but we don't use the > max(date) pattern on incremental filters at this time. instead, try to use our incremental macro, like here. you will need to put your specific column day in there to be used

Changed Incremental command
@dune-eng
Copy link

Workflow run id 10052609558 approved.

@dune-eng
Copy link

Workflow run id 10052609604 approved.

@dune-eng
Copy link

Workflow run id 10052742433 approved.

@safeintern
Copy link
Contributor Author

safeintern commented Jul 29, 2024

@jeff-dude I think that the incremental command is an issue here for this context. I'm forward filling the balances for safes that didn't have their balances changed during their days, so every day will require us to look at the past data to determine the day's data.

What would you suggest here if that is true? a balances difference table?

@dune-eng
Copy link

Workflow run id 10156353388 approved.

@dune-eng
Copy link

Workflow run id 10156353484 approved.

@safeintern
Copy link
Contributor Author

safeintern commented Jul 30, 2024

It worked!! Thank you

@dune-eng
Copy link

Workflow run id 10156414144 approved.

@dune-eng
Copy link

Workflow run id 10156414264 approved.

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dune-eng
Copy link

dune-eng commented Aug 1, 2024

Workflow run id 10200071911 approved.

@dune-eng
Copy link

dune-eng commented Aug 1, 2024

Workflow run id 10200072100 approved.

added balances schema
@dune-eng
Copy link

dune-eng commented Aug 1, 2024

Workflow run id 10200264602 approved.

@dune-eng
Copy link

dune-eng commented Aug 1, 2024

Workflow run id 10200264934 approved.

@safeintern
Copy link
Contributor Author

hey @jeff-dude sorry I am not clear how to update the schema and prices. Can you tell me how to do that?

@dune-eng
Copy link

dune-eng commented Aug 1, 2024

Workflow run id 10200564455 approved.

@dune-eng
Copy link

dune-eng commented Aug 1, 2024

Workflow run id 10200564941 approved.

@jeff-dude
Copy link
Member

hey @jeff-dude sorry I am not clear how to update the schema and prices. Can you tell me how to do that?

let me take over and push some changes, to give you an example. keep a close eye on the commits so it's easier for ya next time 🙏

@jeff-dude jeff-dude added ready-for-merging and removed WIP work in progress labels Aug 1, 2024
@safeintern
Copy link
Contributor Author

thanks @jeff-dude! Reading your commits so that I can successfully create future spells

@jeff-dude jeff-dude merged commit 0a046ab into duneanalytics:main Aug 2, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants