-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bladeswap trades #6274
Add bladeswap trades #6274
Conversation
i see this one is still marked as |
- name: XYKPool_evt_Swap | ||
- name: Vault_Router_evt_Swap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The swap events here may not be very clear:
https://dune.com/queries/3925455
here is an example event log:
https://blastscan.io/tx/0x3f9a53ffe1369136af86c1fff61868ede338be17ace446b8880249c371379d10#eventlog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sample bladeswap_blast.base_trades
based on manually decoding:
https://dune.com/queries/3925627
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However multiple tokens (>2) swapping may happen here.
…llbook into dex-blast-bladeswap-dev
dex/models/trades/blast/platforms/bladeswap_blast_base_trades.sql
Outdated
Show resolved
Hide resolved
doing some (quick) digging around. looks like bladeswap on blast is a fork of velocore. according to velocore docs, dex is inspired by balancer vaults. i wonder if we can use the balancer v2 code (from balancer macro) as inspiration to properly pull this data? |
I will attempt to make use of the |
dex/models/trades/blast/platforms/bladeswap_blast_base_trades.sql
Outdated
Show resolved
Hide resolved
dex/models/trades/blast/platforms/bladeswap_blast_base_trades.sql
Outdated
Show resolved
Hide resolved
i noticed you left out the seed and commented out the test. is that cause we aren't certain the code is correct? or its difficult to navigate the explorer(s) to find tx's to test against? |
…llbook into dex-blast-bladeswap-dev
You are right, I am not very confident with the current implementation (and the seed). |
@@ -0,0 +1,3 @@ | |||
blockchain,project,version,block_date,tx_hash,evt_index,token_bought_address,token_sold_address,block_number,token_bought_amount_raw,token_sold_amount_raw | |||
blast,bladeswap,1,2024-07-22,0x404b62b3acf49cb54739538f6e0d1a71ba68561872f5ee655f364f03c14b9a95,41,0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee,0xd1fedd031b92f50a50c05e2c45af1adb4cea82f4,6415903,28706844152887539,6489521714789132087008 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,3 @@ | |||
blockchain,project,version,block_date,tx_hash,evt_index,token_bought_address,token_sold_address,block_number,token_bought_amount_raw,token_sold_amount_raw | |||
blast,bladeswap,1,2024-07-22,0x404b62b3acf49cb54739538f6e0d1a71ba68561872f5ee655f364f03c14b9a95,41,0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee,0xd1fedd031b92f50a50c05e2c45af1adb4cea82f4,6415903,28706844152887539,6489521714789132087008 | |||
blast,bladeswap,1,2024-07-21,0x01996d5ae5da567e1765b65a03172135b597220f90816a0526961d2c2a6e3631,168,0xd1fedd031b92f50a50c05e2c45af1adb4cea82f4,0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee,6360267,243806794235376124005,1110890207385634 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -17,6 +17,12 @@ sources: | |||
- name: ThrusterFactory_Point_3_Fee_evt_PairCreated | |||
- name: ThrusterPair_V2_1_Fee_evt_Swap | |||
- name: ThrusterFactory_1_Fee_evt_PairCreated | |||
- name: bladeswap_blast |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With extra sources introduced (which I may miss), we may implement the bladeswap.trades
in a more proper way.
as discussed in meeting, let's close this one for now. as always, keep the branch in case. i will communicate the complexity on this project. |
#6271
Contribution type
Please check the type of contribution this pull request is for:
Note: You can safely discard any section below which doesn't apply based on selection above
For new spell(s)
If you are building new spell(s), please provide the following information:
For adding to existing spell lineage
If you are adding to an existing spell lineage, please provide the following information:
For bug fixes
If you are fixing a bug, please provide the following information:
Additional information
Please provide any additional information that might help us review your pull request:
Thank you for your contribution!