-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move nft tokens metadata to tokens subproject #6034
Conversation
@@ -103,7 +103,7 @@ SELECT | |||
ELSE coalesce(agg_mark.aggregator_name, agg1.name, agg2.name) | |||
END as aggregator_name | |||
FROM {{base_trades}} base | |||
LEFT JOIN {{ref('tokens_nft')}} nft | |||
LEFT JOIN {{source('tokens', 'nft')}} nft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi @0xRobin
we are looking to move nft token metadata to tokens subproject, similar to erc20, flipping to source is part of that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this one may be backwards?
all of these edition metadata spells should be moved to tokens subproject as they are dependencies for tokens_nft
lineage. otherwise we create circular dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dbt ls --resource-type model --output name --select decent_optimism_edition_metadata+1
dbt ls --resource-type model --output name --select +decent_optimism_edition_metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing upstream, only token metadata downstream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah you are right I can move this to the tokens subproject
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
running with modified turned off in prod for both projects
This PR moves the existing tokens.nft lineage to the tokens subproject. Solana tokens are not moved for now. This is in preparation for moving the contract mappings lineage