-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix opensea_v3_polygon.events
to include OS trades
#3574
Merged
jeff-dude
merged 7 commits into
duneanalytics:main
from
sohwak:opensea-v4-polygon-20230619
Jun 20, 2023
Merged
Fix opensea_v3_polygon.events
to include OS trades
#3574
jeff-dude
merged 7 commits into
duneanalytics:main
from
sohwak:opensea-v4-polygon-20230619
Jun 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workflow run id 5314286742 approved. |
Workflow run id 5314286734 approved. |
Workflow run id 5314340291 approved. |
Workflow run id 5314340290 approved. |
Workflow run id 5317659151 approved. |
Workflow run id 5317659144 approved. |
Workflow run id 5318188484 approved. |
Workflow run id 5318188478 approved. |
Workflow run id 5318247587 approved. |
Workflow run id 5318247588 approved. |
0xRobin
approved these changes
Jun 20, 2023
jeff-dude
approved these changes
Jun 20, 2023
olgafetisova
pushed a commit
to olgafetisova/spellbook
that referenced
this pull request
Nov 14, 2023
) * fix opensea-v3-polygon to include OS trades * rerun * rerun * rerun * rerun * rerun --------- Co-authored-by: jeff-dude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief comments on the purpose of your changes:
For Dune Engine V2
fee_wallet
andright_hash
, which were previously filtered to get the OS.I've checked that:
General checks:
lowercase_snake_cased
Pricing checks:
coin_id
represents the ID of the coin on coinpaprika.comJoin logic:
Incremental logic: