Making nft tables' trade_category more consistent #1841
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief comments on the purpose of your changes:
Before this PR, we have:
Buy
,Offer Accepted
,Collection Offer Accepted
,Sell
,Auction Settled
,Private Sale
,Private Sales
,Private Buy
,Auction
,Collection Offer
,Collection/Trait
&Trait Offer
.This PR narrows it down to:
Buy
,Offer Accepted
,Collection Offer Accepted
,Sell
(now only for sudoswap, other platforms were switched toOffer Accepted
),Auction Settled
,Private Sale
,Collection Offer Accepted
,Trait Offer Accepted
&Collection/Trait Offer Accepted
(couldn't tell how to split that one intoCollection Offer Accepted
andTrait Offer Accepted
).Those were overlaps with other names so I switched them to the more used name:
Private Sales
,Private Buy
,Auction
.For Dune Engine V2
I've checked that:
General checks:
lowercase_snake_cased
Join logic:
Incremental logic: