Adjusting trades table logic

duneanalytics · Jul 11, 2024 · dbd71d0 · dbd71d0
1 parent 90aceb8
commit dbd71d0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/dex/models/_projects/cow_protocol/arbitrum/cow_protocol_arbitrum_trades.sql b/dex/models/_projects/cow_protocol/arbitrum/cow_protocol_arbitrum_trades.sql
@@ -173,7 +173,7 @@ valued_trades as (
                 WHEN sell_price IS NOT NULL THEN
                     -- Choose the larger of two prices when both not null.
                     CASE
-                        WHEN buy_price IS NOT NULL and buy_price * units_bought > sell_price * units_sold
+                        WHEN buy_price IS NOT NULL and buy_price * COALESCE(units_bought,0) > sell_price * COALESCE(units_sold,0)
                             then buy_price * units_bought
                         ELSE sell_price * units_sold
                         END

diff --git a/dex/models/_projects/cow_protocol/ethereum/cow_protocol_ethereum_trades.sql b/dex/models/_projects/cow_protocol/ethereum/cow_protocol_ethereum_trades.sql
@@ -204,7 +204,7 @@ valued_trades as (
                 WHEN sell_price IS NOT NULL THEN
                     -- Choose the larger of two prices when both not null.
                     CASE
-                        WHEN buy_price IS NOT NULL and buy_price * units_bought > sell_price * units_sold
+                        WHEN buy_price IS NOT NULL and buy_price * COALESCE(units_bought,0) > sell_price * COALESCE(units_sold,0)
                             then buy_price * units_bought
                         ELSE sell_price * units_sold
                         END

diff --git a/dex/models/_projects/cow_protocol/gnosis/cow_protocol_gnosis_trades.sql b/dex/models/_projects/cow_protocol/gnosis/cow_protocol_gnosis_trades.sql
@@ -184,7 +184,7 @@ valued_trades as (
                 WHEN sell_price IS NOT NULL THEN
                     -- Choose the larger of two prices when both not null.
                     CASE
-                        WHEN buy_price IS NOT NULL and buy_price * units_bought > sell_price * units_sold
+                        WHEN buy_price IS NOT NULL and buy_price * COALESCE(units_bought,0) > sell_price * COALESCE(units_sold,0)
                             then buy_price * units_bought
                         ELSE sell_price * units_sold
                         END