Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #71 closePopup #76

Merged
merged 1 commit into from
Apr 29, 2024
Merged

fix #71 closePopup #76

merged 1 commit into from
Apr 29, 2024

Conversation

Dufgui
Copy link
Collaborator

@Dufgui Dufgui commented Apr 29, 2024

Describe your changes

Escape will close popup

I also fix eslint warning

Issue ticket number and link

Checklist before requesting a review

  • I have read and understand the Contributions section
  • I have performed a self-review of my code
  • I ran the unit tests and my PR does not break any tests
  • I documented the changes I've made on the CHANGES.md and followed actual conventions
  • I added a new section on how-to.md (optional)

@dufoli dufoli merged commit e4bde2d into dufoli:master Apr 29, 2024
@Dufgui Dufgui deleted the fix_71 branch May 23, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dufgui @dufoli