-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Refactor examples #588
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10408740639Details
💛 - Coveralls |
jakoschiko
force-pushed
the
jakoschiko_refactor-examples
branch
from
August 11, 2024 14:08
873520c
to
677e0df
Compare
jakoschiko
force-pushed
the
jakoschiko_refactor-examples
branch
from
August 12, 2024 22:24
7e0f08b
to
b5dd787
Compare
The fuzz check failed in the CI due to #590. |
Any idea how to fix? We could slap a ignore on the lint and create an issue. I can then take a look later so we don't block on this. |
Just ignore it and wait for rust-lang/rust#129103 getting merged. |
duesee
force-pushed
the
jakoschiko_refactor-examples
branch
from
August 15, 2024 18:30
c5d8461
to
12befa0
Compare
duesee
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Boooring, everything works :P
duesee
force-pushed
the
jakoschiko_refactor-examples
branch
from
August 15, 2024 18:33
12befa0
to
29d2b4e
Compare
duesee
force-pushed
the
jakoschiko_refactor-examples
branch
from
August 15, 2024 18:36
29d2b4e
to
28cee6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a preparation for the
Fragmentizer
support in Python I want to refactor the existing examples.After this PR there exists the following examples:
fragmentizer.rs
Fragmentizer
client.rs
Fragmentizer
,GreetingCodec
andResponseCodec
.imap-next
server.rs
Fragmentizer
,CommandCodec
,AuthenticateDataCodec
andIdleDoneCodec
.imap-next
The following examples will be removed:
fragmentizer_client.rs
fragmentizer_server.rs
parse_greeting.rs
parse_response.rs
parse_command.rs