Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor examples #588

Merged
merged 2 commits into from
Aug 15, 2024
Merged

refactor: Refactor examples #588

merged 2 commits into from
Aug 15, 2024

Conversation

jakoschiko
Copy link
Collaborator

@jakoschiko jakoschiko commented Aug 11, 2024

As a preparation for the Fragmentizer support in Python I want to refactor the existing examples.

After this PR there exists the following examples:

  • fragmentizer.rs
    • Demonstrates the features of the Fragmentizer
    • Already exists
  • client.rs
    • Demonstrates how a client can be implemented using Fragmentizer, GreetingCodec and ResponseCodec.
    • Reimplements imap-next
    • Added by this PR
  • server.rs
    • Demonstrates how a server can be implemented using Fragmentizer, CommandCodec, AuthenticateDataCodec and IdleDoneCodec.
    • Reimplements imap-next
    • Added by this PR

The following examples will be removed:

  • fragmentizer_client.rs
  • fragmentizer_server.rs
  • parse_greeting.rs
  • parse_response.rs
  • parse_command.rs

@coveralls
Copy link
Collaborator

coveralls commented Aug 11, 2024

Pull Request Test Coverage Report for Build 10408740639

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.981%

Totals Coverage Status
Change from base Build 10256703767: 0.0%
Covered Lines: 11180
Relevant Lines: 12024

💛 - Coveralls

@jakoschiko jakoschiko marked this pull request as ready for review August 12, 2024 22:27
@jakoschiko jakoschiko requested a review from duesee August 12, 2024 22:27
@jakoschiko
Copy link
Collaborator Author

The fuzz check failed in the CI due to #590.

@duesee
Copy link
Owner

duesee commented Aug 14, 2024

Any idea how to fix? We could slap a ignore on the lint and create an issue. I can then take a look later so we don't block on this.

@jakoschiko
Copy link
Collaborator Author

Just ignore it and wait for rust-lang/rust#129103 getting merged.

@duesee duesee force-pushed the jakoschiko_refactor-examples branch from c5d8461 to 12befa0 Compare August 15, 2024 18:30
Copy link
Owner

@duesee duesee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boooring, everything works :P

@duesee duesee force-pushed the jakoschiko_refactor-examples branch from 12befa0 to 29d2b4e Compare August 15, 2024 18:33
@duesee duesee force-pushed the jakoschiko_refactor-examples branch from 29d2b4e to 28cee6a Compare August 15, 2024 18:36
@duesee duesee enabled auto-merge (rebase) August 15, 2024 18:36
@duesee duesee merged commit 630097e into main Aug 15, 2024
26 checks passed
@duesee duesee deleted the jakoschiko_refactor-examples branch August 15, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants