Add Privacy Config feature to control ad attribution reporting #3478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
6 tasks
dus7
force-pushed
the
mariusz/attribution-feature-flag
branch
from
a31cdd7
to
b42379d
Compare
samsymons
approved these changes
Oct 31, 2024
dus7
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Nov 4, 2024
Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: https://app.asana.com/0/0/1208638248015576/f iOS PR: duckduckgo/iOS#3506 macOS PR: duckduckgo/macos-browser#3478 What kind of version bump will this require?: Minor **Optional**: Tech Design URL: CC: **Description**: Adds feature to control the ad attribution reporting on iOS. **Steps to test this PR**: See duckduckgo/iOS#3506 <!-- Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you *know* do not need explicit testing. Using a simulator where a physical device is unavailable is acceptable. --> **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
samsymons
added a commit
that referenced
this pull request
Nov 4, 2024
# By Dax the Duck (4) and others # Via GitHub (2) and Dax the Duck (1) * main: Bump version to 1.113.0 (298) Bump version to 1.113.0 (297) Set marketing version to 1.113.0 Update embedded files Add AI Chat toolbar (#3470) disable testWhenSnapshotIsRestored_ThenRenderingIsSkippedAfterLoading (#3483) Add Privacy Config feature to control ad attribution reporting (#3478) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208638248015576/f
Tech Design URL:
CC:
Description:
No changes in the macOS app. PR only for BSK version update.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation