Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Add To Dock copy #3549

Merged

Conversation

alessandroboron
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/72649045549333/1208577512136638/f

Description:

Updates the new copy defined in Asana in Final Copy - Additional variants section.

Steps to test this PR:
Prerequisites:

  1. Ensure that isOnboardingHighlightsEnabled returns true in OnboardingManager.
  2. Add return VariantIOS(name: "mx", weight: 1, isIncluded: VariantIOS.When.always, features: [.newOnboardingIntroHighlights, .contextualDaxDialogs]) in DefaultVariantManager -> selectVariant() at line 156.

Scenario 1 - Add to Dock is presented from linear onboarding

  1. Ensure that addToDockEnabledState returns .intro in OnboardingManager.
  2. Launch the App.
  3. Ensure the copy is as per the ticket in the PR description.

Scenario 2 - Add to Dock is presented from contextual onboarding

  1. Ensure that addToDockEnabledState returns .contextual in OnboardingManager.
  2. Launch the App.
  3. Ensure the copy is as per the ticket in the PR description.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link

github-actions bot commented Nov 6, 2024

Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against acbd233

@alessandroboron alessandroboron force-pushed the alessandro/onboarding-add-to-dock-copy-update branch from 807f461 to 9476efe Compare November 6, 2024 11:59
@alessandroboron alessandroboron force-pushed the alessandro/onboarding-add-to-dock-copy-update branch from 9476efe to acbd233 Compare November 6, 2024 14:13
Copy link
Contributor

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks as advertised in the task.

@alessandroboron alessandroboron merged commit f7b0e4d into main Nov 7, 2024
13 checks passed
@alessandroboron alessandroboron deleted the alessandro/onboarding-add-to-dock-copy-update branch November 7, 2024 09:48
@alessandroboron alessandroboron restored the alessandro/onboarding-add-to-dock-copy-update branch November 7, 2024 09:50
@alessandroboron alessandroboron deleted the alessandro/onboarding-add-to-dock-copy-update branch November 7, 2024 09:51
samsymons added a commit that referenced this pull request Nov 8, 2024
# By Alessandro Boron (1) and bwaresiak (1)
# Via GitHub
* main:
  Update Attribution logic to fix state issues  (#3548)
  Update Add To Dock copy (#3549)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants