Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DuckPlayer: Fix YouTube shorts issue #3392

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

afterxleep
Copy link
Collaborator

@afterxleep afterxleep commented Sep 25, 2024

Task/Issue URL: https://app.asana.com/0/1204099484721401/1208399924957022/f

Description:

  • Fixes an issue in where Youtube Shorts UI would break if DuckPlayer is enabled

Steps to test this PR:

  1. Make yourself an internal user
  2. Add custom config https://www.jsonblob.com/api/1285150467314016256
  3. Set DuckPlayer to 'always ask'
  4. Go to Youtube.com and search for "Metallica Shorts" or directly to: https://m.youtube.com/results?sp=mAEA&search_query=Metallica+shorts
  5. Tap and watch a few "Shorts"; use the back button to return.
  6. Watch a "Regular" video from the list below and confirm it launches in DuckPlayer

@afterxleep afterxleep changed the title Bump BSK to 196.0.0.-1 DuckPlayer: Fix YouTube shorts issue Sep 25, 2024
@afterxleep afterxleep marked this pull request as ready for review September 25, 2024 13:57
@Bunn
Copy link
Contributor

Bunn commented Sep 25, 2024

Simulator Screen Recording - iPhone 16 Pro - 2024-09-25 at 15 25 08

@afterxleep afterxleep merged commit 98bdba2 into hotfix/7.138.2 Sep 25, 2024
21 checks passed
@afterxleep afterxleep deleted the daniel/duckplayer.shorts.fix branch September 25, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants