Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phishing Detection Library Implementation #3336

Merged
merged 6 commits into from
Sep 10, 2024
Merged

Phishing Detection Library Implementation #3336

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b4a193f
Point to phishing-detection-integration branch
not-a-rootkit Sep 9, 2024
90a0bed
Rename branch
not-a-rootkit Sep 9, 2024
3cf8e34
Update FeatureFlag capitalization
not-a-rootkit Sep 9, 2024
0c5c8ff
Update remote branch to make isPhishing optional
not-a-rootkit Sep 9, 2024
12733d9
Bump BSK version
not-a-rootkit Sep 10, 2024
64a8634
Merge branch 'main' into tespach/phishing-detection
not-a-rootkit Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Core/FeatureFlag.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ extension FeatureFlag: FeatureFlagSourceProviding {
case .duckPlayer:
return .remoteReleasable(.feature(.duckPlayer))
case .sslCertificatesBypass:
return .remoteReleasable(.subfeature(sslCertificatesSubfeature.allowBypass))
return .remoteReleasable(.subfeature(SslCertificatesSubfeature.allowBypass))
case .syncPromotionBookmarks:
return .remoteReleasable(.subfeature(SyncPromotionSubfeature.bookmarks))
case .syncPromotionPasswords:
Expand Down
4 changes: 2 additions & 2 deletions DuckDuckGo.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10712,8 +10712,8 @@
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit";
requirement = {
kind = exactVersion;
version = 191.2.2;
branch = "tespach/phishing-detection-feature";
kind = branch;
};
};
9F8FE9472BAE50E50071E372 /* XCRemoteSwiftPackageReference "lottie-spm" */ = {
Expand Down
10 changes: 5 additions & 5 deletions DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/DuckDuckGo/BrowserServicesKit",
"state" : {
"revision" : "660971f355c2288ebd3041e92d9674abd9e3a3e0",
"version" : "191.2.2"
"branch" : "tespach/phishing-detection-feature",
"revision" : "faedfb154ff50036eca87d88122b2e3462678276"
}
},
{
Expand Down Expand Up @@ -122,8 +122,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/duckduckgo/privacy-dashboard",
"state" : {
"revision" : "665b23dc656c9f787494620494f8e56098a900b2",
"version" : "5.1.1"
"branch" : "mgurgel/phishing-warning",
"revision" : "24ef446823cc116d06a650df0002803f9915b10f"
}
},
{
Expand All @@ -138,7 +138,7 @@
{
"identity" : "swift-argument-parser",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-argument-parser.git",
"location" : "https://github.com/apple/swift-argument-parser",
"state" : {
"revision" : "0fbc8848e389af3bb55c182bc19ca9d5dc2f255b",
"version" : "1.4.0"
Expand Down
Loading