Prevent making Favicons network call in NewTabPageFavoritesModelTests #9285
Triggered via pull request
November 21, 2024 14:33
dus7
Status
Success
Total duration
12m 21s
Artifacts
–
pr.yml
on: pull_request
SwiftLint
36s
ShellCheck
5s
Unit Tests
11m 54s
Make Release Build
12m 9s
Annotations
26 warnings and 3 notices
|
ShellCheck
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
SwiftLint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Unit Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, mikepenz/action-junit-report@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Unit Tests
xcbeautify 2.15.0 is already installed and up-to-date.
To reinstall 2.15.0, run:
brew reinstall xcbeautify
|
|
Unit Tests:
Core/StatisticsLoader.swift#L69
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Unit Tests:
Core/StatisticsLoader.swift#L91
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Unit Tests:
Core/StatisticsLoader.swift#L121
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Unit Tests:
Core/StatisticsLoader.swift#L150
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Unit Tests:
Core/SyncBookmarksAdapter.swift#L199
'taskID' mutated after capture by sendable closure
|
|
Unit Tests:
Core/Pixel.swift#L269
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Unit Tests
Accent color ‘AccentColor’ is not present in any asset catalogs.
|
|
Unit Tests
Background color ‘WidgetBackground’ is not present in any asset catalogs.
|
|
Unit Tests:
DuckDuckGo/FavoritesDisplayMode+UserDefaults.swift#L23
extension declares a conformance of imported type 'FavoritesDisplayMode' to imported protocol 'LosslessStringConvertible'; this will not behave correctly if the owners of 'Bookmarks' introduce this conformance in the future
|
|
Unit Tests:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/Debug-iphonesimulator/WidgetsExtension.build/DerivedSources/GeneratedAssetSymbols.swift#L394
The "CreditCard-32-Color" image asset name resolves to the symbol "creditCard32" which already exists. Try renaming the asset.
|
|
Make Release Build
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/[email protected], actions/checkout@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Make Release Build:
DerivedData/Build/Products/Release-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
|
|
Make Release Build:
Core/Pixel.swift#L269
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Make Release Build:
Core/StatisticsLoader.swift#L69
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Make Release Build:
Core/StatisticsLoader.swift#L91
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Make Release Build:
Core/StatisticsLoader.swift#L121
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Make Release Build:
Core/StatisticsLoader.swift#L150
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Make Release Build:
Core/SyncBookmarksAdapter.swift#L199
'taskID' mutated after capture by sendable closure
|
|
Make Release Build:
DerivedData/Build/Products/Release-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
|
|
Make Release Build:
Core/Pixel.swift#L269
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Make Release Build:
Core/StatisticsLoader.swift#L69
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Make Release Build
xcbeautify 2.15.0 is already installed and up-to-date.
To reinstall 2.15.0, run:
brew reinstall xcbeautify
|
|
Unit Tests
Skipped UnitTests.AutofillLoginListViewModelTests.testWhenBreakageReporterConfigEnabledAndReportAlreadyRecentlySavedThenShowBreakageReporterIsFalse
|
|
Unit Tests
Skipped UnitTests.UsageSegmentationCalculationTests.testPerformance
|
|
Unit Tests
Skipped UnitTests.WebCacheManagerTests.testWhenClearedWithDataStoreContainerThenDDGCookiesAreRetained
|