Skip to content
This repository has been archived by the owner on Jan 10, 2019. It is now read-only.

set downgrade flag and return #206

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from
Open

set downgrade flag and return #206

wants to merge 1 commit into from

Conversation

jdorweiler
Copy link
Contributor

Reviewer:

Description:

This seems to fix the https redirect loops but needs more testing.

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laurengarcia laurengarcia Awaiting requested review from laurengarcia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jdorweiler