This repository has been archived by the owner on Jan 10, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 42
broken site button #153
Open
jdorweiler
wants to merge
2
commits into
beta
Choose a base branch
from
jd/feedback-button
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
broken site button #153
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,8 +8,8 @@ $color--neutral-bg: #f5f5f5; | |
|
||
/* Popup */ | ||
$popup__width: 270px; | ||
$popup__height: 505px; | ||
$popup__height--moz: 520px; | ||
$popup__height: 540px; | ||
$popup__height--moz: 540px; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Notice that originally the heights across browsers were different and now they are the same. Did you verify that the height was correct in FF and Chrome? I would think that FF would be taller. |
||
|
||
/* Cards */ | ||
$card__bg-color: $white; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
const bel = require('bel'); | ||
|
||
module.exports = function (site, text, klass) { | ||
|
||
return bel` | ||
<button class="${klass}" | ||
type="button"> | ||
${text} | ||
</button>`; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
const bel = require('bel'); | ||
const toggleButton = require('./shared/toggle-button'); | ||
const Button = require('./shared/button'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
module.exports = function () { | ||
|
||
|
@@ -32,6 +33,10 @@ module.exports = function () { | |
<span class="site-info__toggle-text">${this.model.whitelistStatusText}</span> | ||
${toggleButton(!this.model.isWhitelisted, 'js-site-toggle pull-right')} | ||
</li> | ||
<li class="site-info__li--report"> | ||
${Button(this.model.domain, 'Report Broken Site', 'button site-info__report-text js-site-report')} | ||
<span class="icon icon__arrow pull-right"></span> | ||
</li> | ||
</ul> | ||
</section>`; | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a new blank line between this and next line, and add a space between properties and values above.