Deprecate PixelKit daily pixel suffixes #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
changed the title
samsymons
commented
Nov 5, 2024
Comment on lines
-236
to
+243
| case .dailyAndCount: | ||
| case .legacyDailyAndCount: |
There was a problem hiding this comment.
This change could trip up anyone who already has a new pixel on a branch that uses dailyAndCount, as the meaning of that value will change after this PR. I'll announce this change to the team before merging it to mitigate this.
federicocappelli
approved these changes
Nov 5, 2024
samsymons
deleted the
sam/migrate-daily-and-count-type-to-legacy-status
branch
samsymons
added a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/0/1208695427490034/f
iOS PR: duckduckgo/iOS#3534
macOS PR: duckduckgo/macos-browser#3509
What kind of version bump will this require?: Major
Description:
This PR renames the existing
dailyAndCountPixelKit type tolegacyDailyAndCount.A new
dailyAndCountcase has been added, but it uses new suffixes.Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template