Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add c makefile #108

Merged
merged 3 commits into from
Nov 15, 2024
Merged

add c makefile #108

merged 3 commits into from
Nov 15, 2024

Conversation

samansmink
Copy link
Collaborator

@samansmink samansmink commented Nov 13, 2024

Makefile for new C/C++ extension template targeting.

This is a similar template to https://github.com/duckdb/extension-template-rs, but then for C/C++ based extensions. Note that this is different from the current standard template https://github.com/duckdb/extension-template/actions which is also intended for C++ extensions but uses DuckDB's C++ API and reuses its build system and test infrastructure.

edit: added a small tweak because things were still broken

Copy link
Collaborator

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good!

I would consider changing the naming structure to be like:

makefiles/
  ... duckdb_extension.make
  ... duckdb_capi_extension_c.make
  ... duckdb_capi_extension_rs.make
  ... duckdb_capi_extension.make

or something along those lines, where it's clear that duckdb_capi_extensions (whatever the naming schema) are different than duckdb_extension.make

I think we are still in time (before adding more repos) to change this with little cost.

@samansmink samansmink merged commit 871db4d into duckdb:main Nov 15, 2024
2 checks passed
@samansmink samansmink deleted the add-c-makefile-2 branch November 15, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants